Add a button "continue editing" after right clicking the mouse when digitizing new geometries - Githubissues

qgib commented 12 years ago

Author Name: Gerhardus Geldenhuis (@ggeldenhuis) Original Redmine Issue: 4461

Redmine category:digitising

When you are adding a new polygon and have just painstakingly traced out a new feature and you accidentally right click to soon there is now way to go back and continue editing. Editing the polygon is not always practical and in trying to recreate the problem for this issue I have managed to reliably crash QGIS when trying to edit a wrongly created polygon. I am attaching an image to show my dilemma hoping it makes things more clear.

Screenshot-1.png (Gerhardus Geldenhuis)

qgib commented 12 years ago

Author Name: Giovanni Manghi (@gioman)

Sorry, one question. After the involuntary right click, which stops editing a geomtery, but not remove it, what is stopping you from restarting to edit the same geometry with the "node toll " tool?

status_id was changed from Open to Feedback

qgib commented 12 years ago

Author Name: Gerhardus Geldenhuis (@ggeldenhuis)

It is possible to edit it with the node tool but painful. Yes I can add new nodes and manipulate them but I can't get back into the same "mode" of editing that I were before which makes editing a lot easier. If I need to use the node tool I have to click on the line and then drag the point rather than just clicking a new point. The attached image is only a small example. If the polygon that you are adding stretches over a larger area and you are halfway in the process when the accidental click happens then rescuing with the node tool is not ideal. It is also not clear from the node tool what I were doing before. If the node tool could put the polygon back into "freshly created" mode that would be brilliant but first price would still be just a small button saying "Go back to edit mode" or something to that effect.

qgib commented 12 years ago

Author Name: Giovanni Manghi (@gioman)

Gerhardus Geldenhuis wrote:

It is possible to edit it with the node tool but painful. Yes I can add new nodes and manipulate them but I can't get back into the same "mode" of editing that I were before which makes editing a lot easier. If I need to use the node tool I have to click on the line and then drag the point rather than just clicking a new point. The attached image is only a small example. If the polygon that you are adding stretches over a larger area and you are halfway in the process when the accidental click happens then rescuing with the node tool is not ideal. It is also not clear from the node tool what I were doing before. If the node tool could put the polygon back into "freshly created" mode that would be brilliant but first price would still be just a small button saying "Go back to edit mode" or something to that effect.

Another question (just to understand if you are using the node tool the right way): you know that the node tool also add nodes? just double click on any point of a segment... this change the picture?

qgib commented 12 years ago

Author Name: Giovanni Manghi (@gioman)

Gerhardus Geldenhuis wrote:

It is possible to edit it with the node tool but painful. Yes I can add new nodes and manipulate them but I can't get back into the same "mode" of editing that I were before which makes editing a lot easier. If I need to use the node tool I have to click on the line and then drag the point rather than just clicking a new point. The attached image is only a small example. If the polygon that you are adding stretches over a larger area and you are halfway in the process when the accidental click happens then rescuing with the node tool is not ideal. It is also not clear from the node tool what I were doing before. If the node tool could put the polygon back into "freshly created" mode that would be brilliant but first price would still be just a small button saying "Go back to edit mode" or something to that effect.

in any case what is your suggestion here? add an option to get a warning message like "really stop editing" every time the right button is clicked?

qgib commented 12 years ago

Author Name: Gerhardus Geldenhuis (@ggeldenhuis)

Hi Yes, I am aware that the node tool can add new nodes, well I just learned it when first typing this request. However adding new nodes with the node tool is not the same as adding new polygon because I don't have the semi transparent polygon guiding what I want to do and the raster underneath is also not visible any more. I might also be tracing a river from north to south over a large extend of the map and having arrived at the bottom of the map make my accidental click. Fixing this with the node tool by adding new nodes and dragging them all the way back up the map is painful and not ideal.

qgib commented 12 years ago

Author Name: Giovanni Manghi (@gioman)

Gerhardus Geldenhuis wrote:

Hi Yes, I am aware that the node tool can add new nodes, well I just learned it when first typing this request. However adding new nodes with the node tool is not the same as adding new polygon because I don't have the semi transparent polygon guiding what I want to do and the raster underneath is also not visible any more. I might also be tracing a river from north to south over a large extend of the map and having arrived at the bottom of the map make my accidental click. Fixing this with the node tool by adding new nodes and dragging them all the way back up the map is painful and not ideal.

the warning message (as option, not by default for sure) as suggested above would be helpful?

qgib commented 12 years ago

Author Name: Giovanni Manghi (@gioman)

I'm asking because the summary of this ticket need to be changed, seems to me wrong and do not describe well the situation and/or how to avoid it

qgib commented 12 years ago

Author Name: Gerhardus Geldenhuis (@ggeldenhuis)

I am suggesting the following: When you right click you get a dialog box showing the attributes that you have defined for the layer and two buttons: Cancel and Ok. Cancel should either Cancel the right click and continue the creation of the polygon or there should be a third button that says "Continue Editing" which should take you back to polygon edit mode and disregard the last right click enabling you to finish the polygon.

I am happy if you want to change the summary. At the time it was the most appropriate I could think of. I found it a bit difficult to capture accurately in words.

qgib commented 12 years ago

Author Name: Giovanni Manghi (@gioman)

When you right click you get a dialog box showing the attributes that you have defined for the layer and two buttons: Cancel and Ok.

this is already the default behavior of QGIS

Cancel should either Cancel the right click and continue the creation of the polygon or there should be a third button that says "Continue Editing" which should take you back to polygon edit mode and disregard the last right click enabling you to finish the polygon.

"cancel" at the moment destroy the edits, so the third button with "continue editing" seems appropriate

subject was changed from Accidental right click looses work to Add a button "continue editing" after right clicking the mouse when digitizing new geometries
category_id was changed from GUI to Digitising
status_id was changed from Feedback to Open
fixed_version_id was configured as Version 2.0.0

qgib commented 11 years ago

Author Name: Pirmin Kalberer (Pirmin Kalberer)

fixed_version_id was changed from Version 2.0.0 to Future Release - Nice to have

qgib commented 7 years ago

Author Name: Giovanni Manghi (@gioman)

easy_fix was configured as 0

frozeng commented 4 years ago

I know it is old but I would like to 2nd this feature - it is very annoying when you right click accidentally and have no way to easily get back to the state you were in before

I would suggest an improvement to the naming of the buttons to Save and Discard as OK and Cancel do not describe what they actually do.

To save having to add another button I propose that the [X] button close the dialogue and returns to the editing mode (as if right click had never been pressed)

andreasneumann commented 4 years ago

@frozeng - "Save" might be misleading. The "OK" button doesn't save the edits. It just adds it to the edit buffer. Saving is a separate step.

But the idea about continuing the editing seems useful. I would opt for a separate button "Continue editing". The dialog has the whole bottom line reserved for such buttons anyway. That empty space can't be used otherwise.

The "X" should act like a "Cancel", normally. That is the normal convention. We shouldn't break with this convention.

frozeng commented 4 years ago

I noticed while using the software later on there is a precedence for the 3 button [Save] [Discard] [Cancel] in this dialogue:

Maybe the "Feature Attribute" dialogue could have the following buttons? [Add] [Discard] [Cancel] or [Add] [Discard] [Continue Editing]

qgis / QGIS

Add a button "continue editing" after right clicking the mouse when digitizing new geometries #14388