qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)
https://qgis.org
GNU General Public License v2.0
10.59k stars 3.01k forks source link

i.fusion.brovey function broken in QGIS' grass plugin #16849

Closed qgib closed 5 years ago

qgib commented 11 years ago

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Original Redmine Issue: 7999 Affected QGIS version: master Redmine category:grass Assignee: Radim Blazek


Under QGIS master, the i.fusion.brovey grass function is broken, in two ways:

  1. It shows the output raster prefix (-outputprefix) as an optional checkbox, when it is a required flag for this function
  2. If the option is checked, the -outputprefix has no string, leading to a number of "Sorry, is not a valid flag" errors before terminating.

It seems that the output raster prefix should a) not be optional, and b) be presented as a text box instead of a check box for users to enter a string prefix.

Discovered this when playing around with the new LANDSAT-8 imagery and trying to do pan-sharpening. It'd be a nice homage to USGS and its new amazing satellite to fix this ;)

Not tested on QGIS 1.8, not sure whether it's a regression or whether i.fusion.brovey never worked through QGIS' grass plugin.

qgib commented 11 years ago

Author Name: Nathan Woodrow (@NathanW2)


The GRASS plugin is no longer maintained. Might be best to try thought Sextante.

qgib commented 11 years ago

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)


Nathan, I wrote to Victor about i.fusion.brovey missing in Sextante. It's a function that's harder to implement than the average GRASS raster function, and his to-do list is too busy to get this by 2.0. This is my plan B ;)

I thought that, with recent commits by Radim to fix the grass plugin, it'd still be supported in 2.0. Oh well, nevertheless, if this can quickly be fixed, that'd be appreciated and open the door for pan sharpening within QGIS (currently not possible through any other QGIS tools)

qgib commented 11 years ago

Author Name: Radim Blazek (@blazek)


Nathan Woodrow wrote:

The GRASS plugin is no longer maintained. Might be best to try thought Sextante.

I have fixed all GRASS blockers. The GRASS plugin and QGIS is also used by regular GRASS users who keep data in GRASS dataset for who the Sextante is not suitable. Until we decide to completely remove the GRASS plugin we have to maintain it.

qgib commented 9 years ago

Author Name: Markus Neteler (Markus Neteler)


FWIW: In GRASS GIS 7, i.fusion.brovey has been retired and replaced by the more powerful i.pansharpen (http://grass.osgeo.org/grass70/manuals/i.pansharpen.html).

All these updates are documented here:

http://trac.osgeo.org/grass/wiki/Grass7/NewFeatures#Replacedandremovedmodules

http://trac.osgeo.org/grass/wiki/Grass7/NewFeatures#Optionschanges

qgib commented 8 years ago

Author Name: Radim Blazek (@blazek)


Fixed in changeset "46ed98a7ef41f861b4cd216e2dfd851f254979ee".


qgib commented 8 years ago

Author Name: Radim Blazek (@blazek)


The same as #14520.