Prevent creation of recursive models (or provide solution to break out of loops) - Githubissues

qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)

https://qgis.org

GNU General Public License v2.0

10.31k stars 2.97k forks source link

Prevent creation of recursive models (or provide solution to break out of loops) #18423

Open qgib opened 10 years ago

qgib commented 10 years ago

Author Name: Anita Graser (@anitagraser) Original Redmine Issue: 9909 Affected QGIS version: 2.4.0 Redmine category:processing/modeller Assignee: Victor Olaya

Currently, it is possible to include the model itself into the model workflow thus creating a model which calls itself. Of course this causes errors.

qgib commented 10 years ago

Author Name: Victor Olaya (@volaya)

mmm, actually it shouldn't cause error. The modeler is designed to allow nested models. So it's a bug, but the solution is not removing models in the list of algorithms in the model, but fixing it.

qgib commented 10 years ago

Author Name: Anita Graser (@anitagraser)

Sorry for being unclear :-)

It's great that modeler allows nested models! I just wanted to suggest that it might make sense to check if the user is creating circular references in his models. If model A calls model A to get to its results, it won't ever stop, or is there a way to break out of such loops?

qgib commented 10 years ago

Author Name: Giovanni Manghi (@gioman)

subject was changed from It's possible to create recursive models to It's possible to stop recursive models?

qgib commented 10 years ago

Author Name: Anita Graser (@anitagraser)

subject was changed from It's possible to stop recursive models? to Prevent creation of recursive models (or provide solution to break out of loops)

qgib commented 9 years ago

Author Name: Giovanni Manghi (@gioman)

category_id removed 64
crashes_corrupts_data was configured as 0
version was configured as 2.4.0
project_id was changed from 78 to 17

qgib commented 9 years ago

Author Name: Giovanni Manghi (@gioman)

category_id was configured as Processing/Modeller

qgib commented 8 years ago

Author Name: Victor Olaya (@volaya)

fixed in #a549ded47bf6bfebc050d64502ac3dc8b9e921d6

qgib commented 8 years ago

Author Name: Victor Olaya (@volaya)

status_id was changed from Open to Closed

YoannQDQ commented 1 year ago

This still crashes QGIS (3.30)