qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)
https://qgis.org
GNU General Public License v2.0
10.61k stars 3.01k forks source link

Geometry Checks is slow when features count is enabled #29349

Open qgib opened 5 years ago

qgib commented 5 years ago

Author Name: Alexey T (@Xeenych) Original Redmine Issue: 21533 Affected QGIS version: 3.6.0 Redmine category:digitising


There is a new option in layer properties -> digitizing -> Geometry Checks.

When activated and also features count is enabled, it checks geometry for every feature in a layer after every singel vertex edit.

My layer have 20000 features. These checks are very slow.

Shouldn't this feature check geometry validity of a current feature being edited?

qgib commented 5 years ago

Author Name: Giovanni Manghi (@gioman)


I have tested on a 4000 features layers, each with thousands of vertexes and does not seems to be an issue. Can you attach sample data? thanks.


qgib commented 5 years ago

Author Name: Alexey T (@Xeenych)


You are right. I found the cause.

When "show feature count" is enabled, layer editing is very slow. QGIS is recounting features after every vertex edit.

see the video https://yadi.sk/d/sFMsl3LclCerUA

Shouldn't it recount them on saving?

qgib commented 5 years ago

Author Name: Giovanni Manghi (@gioman)


When activated, it checks geometry for every feature in a layer after every singel vertex edit.

My layer have 20000 features. These checks are very slow.

Shouldn't this feature check geometry validity of a current feature being edited? to There is a new option in layer properties -> digitizing -> Geometry Checks.

When activated and also features count is enabled, it checks geometry for every feature in a layer after every singel vertex edit.

My layer have 20000 features. These checks are very slow.

Shouldn't this feature check geometry validity of a current feature being edited?

Pedro-Murteira commented 2 years ago

After testing with multiple datasets, I can still confirm that this issue occurs on layers with a considerable amount of features. Tested on a layer with 8000 features and this was not an issue at all. On the other hand, I also tested on a layer with 64000 features, and I could replicate this behaviour. As mentioned before on this issue, this is due to the fact that QGIS recounts features after every vertex edit. This counting could be done when saving the changes made to the layer instead. IMO this issue should be a Feature Request.