search

qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)
https://qgis.org
GNU General Public License v2.0
10.3k stars 2.96k forks source link

Graphical modeler - Browse for "Input layer" -> "OK"-button doesn't work as intended #43007

Open pathmapper opened 3 years ago

pathmapper commented 3 years ago

Describe the bug If a selection in the Browse for "Input layer" dialogue is confirmed with the "OK"-button, the selection is not used for the Input layer field. Instead only the Browse for "Input layer" dialogue is closed and there is no change for the Input layer field.

How to Reproduce

  1. Crate a new model

  2. Add e.g. the "Retain fields" algorithm

  3. Choose "Browse for layer..." for the input layer grafik

  4. Select a layer and click "OK" grafik

  5. See error --> Nothing has changed for the Input layer field of the algorithm.

QGIS and OS versions

QGIS version 3.18.2-Zürich QGIS code revision 515138c171 Compiled against Qt 5.11.2 Running against Qt 5.11.2 Compiled against GDAL/OGR 3.1.4 Running against GDAL/OGR 3.1.4 Compiled against GEOS 3.8.1-CAPI-1.13.3 Running against GEOS 3.8.1-CAPI-1.13.3 Compiled against SQLite 3.29.0 Running against SQLite 3.29.0 PostgreSQL Client Version 11.5 SpatiaLite Version 4.3.0 QWT Version 6.1.3 QScintilla2 Version 2.10.8 Compiled against PROJ 6.3.2 Running against PROJ Rel. 6.3.2, May 1st, 2020 OS Version Windows 10 (10.0) Active python plugins QuickOSM; db_manager; MetaSearch; processing

Additional context Instead using the "OK"-button, doubleclick on the layer works.

roya0045 commented 3 years ago

If you try with a local file/layer, does it work fine?

pathmapper commented 3 years ago

Nope, same issue with local GPKG layer.

gioman commented 3 years ago 
5\. See error --> Nothing has changed for the _Input layer_ field of the algorithm.

@pathmapper worked fine for me with SHP, a layer within a GPKG and a postGIS layer. Trying to select a WFS layer it returns a clear

The “Retain fields” algorithm is invalid, because: Parameter INPUT is mandatory

This on QGIS master on Ubuntu 20.04.

pathmapper commented 3 years ago

@gioman just tried with QGIS master on Ubuntu 20.04.:

For me this is not limited to a WFS layer, the issue appears also with SHP and GPKG.

Please have a look at the following GIF where the OK button doesn't consider the selected layer (please note that at the end of the demonstration there's a doubleclick on the GPKG layer to show that it works with doubleclick).

issue_43007

pathmapper commented 3 years ago

@gioman Did you maybe use Select File...instead Browse for Layer... for your test?

gioman commented 3 years ago

Weird, I can replicate today.

Pedro-Murteira commented 2 years ago

Unable to reproduce it on Windows 10. (QGIS 3.22.3.)

pathmapper commented 2 years ago

Just reproduced with 3.22.3 and master on Ubuntu 20.04.3.

Pedro-Murteira commented 2 years ago

I was unable to reproduce this on macOS Monterey 12.1 aswell, just tested.

gioman commented 2 years ago

Just reproduced with 3.22.3 and master on Ubuntu 20.04.3.

I also replicated on Windows. There is no (more?) error, but selecting the layer and clicking "ok" won't apply it. It only works by double clicking on it.