GUI issues in the data-defined size legend dialog - Githubissues

qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)

https://qgis.org

GNU General Public License v2.0

10.6k stars 3.01k forks source link

GUI issues in the data-defined size legend dialog #45993

Open DelazJ opened 3 years ago

DelazJ commented 3 years ago

What is the bug or the crash?

Some GUI issues in the data-defined size legend dialog:

we should either grey out or hide the "Options" section if "collapsed" mode is not selected. And remove the "collapse only" mention from the title. I don't think there's any place we do this
The Symbol legend is greyed out. I think it's a fix because in some earlier versions it was possible to change the symbol (which IMHO didn't make sense). But using a push button with a label ended with '...' suggesting a possible dialog opening looks weird to me. Do we ever need to display the legend symbol there if there's a working preview?

Steps to reproduce the issue

see above

Versions

QGIS 3.22+

Supported QGIS version

[ ] I'm running a supported QGIS version according to the roadmap.

New profile

[ ] I tried with a new QGIS profile

Additional context

No response

ismailsunni commented 2 years ago

Hi @DelazJ I made a fix for the first item, but for the second one, it seems in the code it may be called. I found there is this code https://github.com/qgis/QGIS/blob/master/src/gui/vector/qgsdiagramproperties.cpp#L1088 that will enable the button. But, I am not sure when or where it's getting called.