Identify panel should allow all view options in "current layer" mode

AlisterH commented 1 year ago

What is the bug or the crash?

The identify panel has a "View" control at the bottom, with the choices "Tree", "Table" and "Graph". For some reason this control is disabled when "Mode" is set to "Current Layer". I don't think this makes sense, because "Current Layer" mode can still identify multiple features.

Steps to reproduce the issue

Use the identify tool.
Set "Mode" to "Current Layer".
See that the "View" control is greyed out.

Versions

QGIS version 3.28.2-Firenze QGIS code revision b47e00ba601 Qt version 5.15.3 Python version 3.9.5 GDAL/OGR version 3.6.1 PROJ version 9.1.1 EPSG Registry database version v10.076 (2022-08-31) GEOS version 3.11.1-CAPI-1.17.1 SQLite version 3.39.4 PDAL version 2.4.3 PostgreSQL client version unknown SpatiaLite version 5.0.1 QWT version 6.1.6 QScintilla2 version 2.13.1 OS version Windows 10 Version 2009

Active Python plugins AutoLayoutTool 1.1 autoSaver 2.6 batchvectorlayersaver 0.9 BulkVectorExport 1.1 cartolinegen 3.2.2 changeDataSource 3.1 civilplan 1.0 ClipMultipleLayers 3.2.0 DataPlotly 3.9.2 deactivate_active_labels 0.5 dimensioning 0.2 Equal_area_slope_QGIS_Plugin 0.1 FlowEstimator 0.21 Generalizer3 1.0 geo_sim_processing 1.2.0 GroupStats 2.2.6 ImageServerConnector 2.1.1 ImportPhotos 3.0.5 joinmultiplelines Version 0.4.1 karika 1.5 kart 1.0.4 LayerBoard 1.0.1 linz-data-importer 2.3.1 loadthemall 3.3.0 map-units-per-pixel 0.2.1 MemoryLayerSaver 4.0.4 nominatim 1.4.5 pathfinder version 0.4.2 PluginLoadTimes 3.0.1 plugin_reloader 0.9.3 precisioncursor4qgis-main 0.2E ProcessX 1.4 QCopycanvas 0.5 qgis_resource_sharing 1.0.0 QuickMultiAttributeEdit3 version 3.0.3 quicksaveqml 0.1.6 quick_map_services 0.19.33 replace_geometry 2.0 splitmultipart 1.0.0 SRTM-Downloader 3.1.17 statist 3.2 TerrainShading 0.9.3 valuetool 3.0.15 volume_calculation_tool 0.4 wbt_for_qgis 1.0.7 grassprovider 2.12.99 processing 2.12.99 sagaprovider 2.12.99 pcraster_tools 0.2.0

Supported QGIS version

[X] I'm running a supported QGIS version according to the roadmap.

New profile

[X] I tried with a new QGIS profile

Additional context

No response

uclaros commented 1 year ago

I don't think this is a bug. Table and Graph views apply to raster layers only. When in Current Layer mode, the combo box is enabled when the current layer is a raster but disabled for vectors.

AlisterH commented 1 year ago

Looks like you are right about Graph view, but not Table view.

uclaros commented 1 year ago

I guess you're right about Table view, although it was intentionally done like that (see https://github.com/qgis/QGIS/commit/cc1f24e78a961c7fa003d0957f4ab8adf9711f37). Table view could also be useful for vector layers indeed.

agiudiceandrea commented 1 year ago

Moreover, there is a glitch... the "View" control is enabled for the first time the Identify Features map tool is used

https://user-images.githubusercontent.com/16253859/217909332-0ae88e44-97b8-4ddb-b4e2-b29d66c66aae.mp4

Anyway it seems to me that, afterwards, the "View" control is disabled not only for the "Current Layer" mode, but also for the other modes if none of the layers is a raster layer.

qgis / QGIS