Viewing a Layer's properties marks the QGIS project as changed/unsaved

[PeterBrodersen]

What is the bug or the crash?

When viewing a layer's properties (by right-clicking and selecting Properties or by double-clicking the layers in the Layers panel) the project is now marked as changed - as denoted with a "*" in the window title before the file name.

When closing the project QGIS asks if the user wants to save the project. Even if it hasn't in actuality been changed.

Steps to reproduce the issue

1. Create a new project.
2. Create a layer. Any layer will do.
3. Save the project.
4. Open the properties for the layer

The project is now marked as changed/unsaved even if no change has taken place. Simply viewing properties shouldn't be regarded as a change.

Versions

QGIS version | 3.30.1-'s-Hertogenbosch | QGIS code revision | 9035a01e -- | -- | -- | -- Qt version | 5.15.3 Python version | 3.9.5 GDAL/OGR version | 3.6.3 PROJ version | 9.2.0 EPSG Registry database version | v10.082 (2023-02-06) GEOS version | 3.11.2-CAPI-1.17.2 SQLite version | 3.41.1 PDAL version | 2.5.2 PostgreSQL client version | unknown SpatiaLite version | 5.0.1 QWT version | 6.1.6 QScintilla2 version | 2.13.1 OS version | Windows 10 Version 2009   |   |   |   Active Python plugins AddressToolsDK | 0.1 Datafordeler | 1.3 Dataforsyningen | 0.4 debug_vs | 0.7 geosearch_dk | 1.3.0 go2streetview | 8.6 JSONEater | 0.3 plugin_reloader | 0.9.3 qgis-maptiler-plugin | 3.1.1 QuickOSM | 2.1.1 QuickWKT | 3.1 sparqlunicorn | 0.12.2 db_manager | 0.1.20 grassprovider | 2.12.99 MetaSearch | 0.3.6 processing | 2.12.99 QGIS version 3.30.1-'s-Hertogenbosch QGIS code revision [9035a01e](https://github.com/qgis/QGIS/commit/9035a01e) Qt version 5.15.3 Python version 3.9.5 GDAL/OGR version 3.6.3 PROJ version 9.2.0 EPSG Registry database version v10.082 (2023-02-06) GEOS version 3.11.2-CAPI-1.17.2 SQLite version 3.41.1 PDAL version 2.5.2 PostgreSQL client version unknown SpatiaLite version 5.0.1 QWT version 6.1.6 QScintilla2 version 2.13.1 OS version Windows 10 Version 2009 Active Python plugins AddressToolsDK 0.1 Datafordeler 1.3 Dataforsyningen 0.4 debug_vs 0.7 geosearch_dk 1.3.0 go2streetview 8.6 JSONEater 0.3 plugin_reloader 0.9.3 qgis-maptiler-plugin 3.1.1 QuickOSM 2.1.1 QuickWKT 3.1 sparqlunicorn 0.12.2 db_manager 0.1.20 grassprovider 2.12.99 MetaSearch 0.3.6 processing 2.12.99 ### Supported QGIS version - [X] I'm running a supported QGIS version according to the roadmap. ### New profile - [ ] I tried with a new QGIS profile ### Additional context _No response_

[jakimowb]

I can confirm this for 3.31 (windows)

I wrote a *.qgs project file before and after opening the layer properties. The only difference was the saveDataTime attribute (as expected)

<qgis saveDateTime="2023-04-20T16:44:34" ... >

but nothing else was changed.

[alexbruy]

This happens only when layer proerties dialog is closed with "OK" and does not happen when layer properties dialog is closed with "Cancel".