search

qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)
https://qgis.org
GNU General Public License v2.0
10.43k stars 2.98k forks source link

"Set 3D scene on 2D map view" labels the extent as "map view" instead of "drawn on canvas" #55765

Open DelazJ opened 9 months ago

DelazJ commented 9 months ago

What is the bug or the crash?

In a 3D map view, Configuration dialog --> General, you can set a 2D extent to limit the 3D map scene. This can be done using the "Draw on canvas" button and you'll get as group name Extent (current: drawn on canvas) This tool has a shortcut on the 3D map view toolbar, in the options drop-down menu: "Set 3D scene on 2D map view". Use it to draw an extent on the canvas and watch the Configure --> General tab: the group title is wrongly named Extent (current: map view)

Steps to reproduce the issue

See above

Versions

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">

QGIS version | 3.35.0-Master | QGIS code revision | 3ba62a8bcc5 -- | -- | -- | -- Qt version | 5.15.8 Python version | 3.11.2 GDAL/OGR version | 3.6.2 PROJ version | 9.1.1 EPSG Registry database version | v10.076 (2022-08-31) GEOS version | 3.11.1-CAPI-1.17.1 SQLite version | 3.40.1 PDAL version | 2.6.0 PostgreSQL client version | 15.5 (Debian 15.5-0+deb12u1) SpatiaLite version | 5.0.1 QWT version | 6.1.4 QScintilla2 version | 2.13.3 OS version | Debian GNU/Linux 12 (bookworm)   |   |   |   This copy of QGIS writes debugging output.   |   |   |   Active Python plugins qgis_resource_sharing | 1.0.0 db_manager | 0.1.20 MetaSearch | 0.3.6 processing | 2.12.99

Supported QGIS version

New profile

Additional context

No response

uclaros commented 9 months ago

Do you mean:

  1. Go to Options > Configure > General
  2. Switch back to 3D view without closing the Configuration Dialog
  3. Set 3D scene on 2D map view
  4. See Extent (current: map view)

or

  1. Set 3D scene on 2D map view
  2. Go to Options > Configure > General
  3. See Extent (current: map view)

?

If it's the later, then this is how the widget works elsewhere too, eg. when editing bookmarks

DelazJ commented 9 months ago

I think it is more the latter scenario. I thought the "current: map view" means the extent corresponds to the 2D map current extent (where current is the moment it is generated, of course). When you use the draw on canvas, it is labeled "drawn on canvas". The "set 3D scene on 2D map view" being a shortcut to the "Draw on canvas", should it not return the same label?

https://github.com/qgis/QGIS/assets/7983394/2d8ec767-5572-4824-a9e5-17e44d699838

uclaros commented 9 months ago

This is a limitation of the QgsExtentGroupBox, drawn on canvas may only appear only after clicking the Draw on Canvas button (this is the same behavior for bookmarks too). We could however identify when the 3d extent matches the project extent and use map view in that case, and when it does not matches we could use the user defined.

DelazJ commented 9 months ago

We could however identify when the 3d extent matches the project extent and use map view in that case, and when it does not matches we could use the user defined.

You mean, when using the "Set 3D scene on 2d map view" shortcut, right? It could indeed avoid the confusing "map view" text.

uclaros commented 9 months ago

You mean, when using the "Set 3D scene on 2d map view" shortcut, right?

Both the shortcut or the Draw on Canvas button in the configuration dialog