qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)
https://qgis.org
GNU General Public License v2.0
10.59k stars 3.01k forks source link

Align rasters tool: Missing OUTPUT parameter in GUI of the processing tool #57096

Open Jannik-Schilling opened 7 months ago

Jannik-Schilling commented 7 months ago

What is the bug or the crash?

The processing tool "Align Rasters" cannot be executed. The error message says: "Unable to create output file" but in the GUI of the tool the output file cannot be defined.

Steps to reproduce the issue

Execution will fail due to missing output file definition: grafik

Versions

QGIS version | 3.36.1-Maidenhead | QGIS code revision | 3e589453 -- | -- | -- | -- Qt version | 5.15.3 Python version | 3.9.18 Compiled against GDAL/OGR | 3.8.4 | Running against GDAL/OGR | 3.8.3 PROJ version | 9.3.1 EPSG Registry database version | v10.098 (2023-11-24) GEOS version | 3.12.1-CAPI-1.18.1 SQLite version | 3.41.1 PDAL version | 2.6.0 PostgreSQL client version | 16.2 SpatiaLite version | 5.1.0 QWT version | 6.1.6 QScintilla2 version | 2.13.4 OS version | Windows 10 Version 2009   |   |   |   Active Python plugins generate_swmm_inp | 0.34 OSMDownloader | 1.0.3 plugin_reloader | 0.9.3 processing_saga_nextgen | 1.0.0 quick_map_services | 0.19.34 WaterNetAnalyzer-master | 1.8 db_manager | 0.1.20 grassprovider | 2.12.99 MetaSearch | 0.3.6 processing | 2.12.99 QGIS version 3.36.1-Maidenhead QGIS code revision [3e589453](https://github.com/qgis/QGIS/commit/3e589453) Qt version 5.15.3 Python version 3.9.18 Compiled against GDAL/OGR 3.8.4 Running against GDAL/OGR 3.8.3 PROJ version 9.3.1 EPSG Registry database version v10.098 (2023-11-24) GEOS version 3.12.1-CAPI-1.18.1 SQLite version 3.41.1 PDAL version 2.6.0 PostgreSQL client version 16.2 SpatiaLite version 5.1.0 QWT version 6.1.6 QScintilla2 version 2.13.4 OS version Windows 10 Version 2009 Active Python plugins generate_swmm_inp 0.34 OSMDownloader 1.0.3 plugin_reloader 0.9.3 processing_saga_nextgen 1.0.0 quick_map_services 0.19.34 WaterNetAnalyzer-master 1.8 db_manager 0.1.20 grassprovider 2.12.99 MetaSearch 0.3.6 processing 2.12.99 ### Supported QGIS version - [X] I'm running a supported QGIS version according to [the roadmap](https://www.qgis.org/en/site/getinvolved/development/roadmap.html#release-schedule). ### New profile - [X] I tried with a new [QGIS profile](https://docs.qgis.org/latest/en/docs/user_manual/introduction/qgis_configuration.html#working-with-user-profiles) ### Additional context _No response_
agiudiceandrea commented 7 months ago

@Jannik-Schilling, you need to select each input layer, click on "Configure Raster" and set the output raster layer path/name and the other parameters.

agiudiceandrea commented 7 months ago

@DelazJ @alexbruy, maybe the algorithm documentation in the user manual and the algorithm short help need to be improved in order to explain how to properly set the output raster parameter in the GUI.

Jannik-Schilling commented 7 months ago

ahhh Thanks. Indeed I just used the checkboxes and didn´t click on "Configure Raster" because it didn´t seem necessary

Here´s a quick proposal for the helpstring: https://github.com/qgis/QGIS/commit/4dcda33eb93b38599bdc6c18386178101f6cc43f

Jannik-Schilling commented 7 months ago

Maybe missing user input for output files should also be ckecked here: https://github.com/qgis/QGIS/blob/c67e81ba03b82a482b51aa5064136d70c292840c/src/analysis/processing/qgsalgorithmalignsingleraster.cpp#L121

Maybe something like ...

if ( !outputFile )
    throw QgsProcessingException( invalidRasterError( parameters, QStringLiteral( "OUTPUT" ) ) );

... for each input layer

agiudiceandrea commented 7 months ago

@Jannik-Schilling it would be nice if you submitted a Pull Request with your proposed fixes.

github-actions[bot] commented 6 months ago

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale". If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue. In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue. If there is no further activity on this issue, it will be closed in a week.