Digitizing: rubberband is not deleted when editing mode is turned off

[JuhoErvasti]

What is the bug or the crash?

When you're for example digitizing a new feature and you make the layer not editable the rubberband doesn't disappear:

Steps to reproduce the issue

1. Create a polygon layer
2. Start adding a new feature
3. Turn layer editing off
4. Observe as the rubberband persists

Versions

QGIS version	3.39.0-Master
QGIS code revision	d85f3c2a28
Libraries
Qt version	5.15.3
Python version	3.10.12
GDAL/OGR version	3.6.4
PROJ version	9.1.1
EPSG Registry database version	v10.076 (2022-08-31)
GEOS version	3.11.1-CAPI-1.17.1
SQLite version	3.37.2
PDAL version	2.5.0
PostgreSQL client version	16.4 (Ubuntu 16.4-1.pgdg22.04+1)
SpatiaLite version	5.0.1
QWT version	6.1.4
QScintilla2 version	2.11.6
OS version	Ubuntu 22.04.4 LTS
This copy of QGIS writes debugging output.
Active Python plugins
processing	2.12.99
MetaSearch	0.3.6
db_manager	0.1.20
grassprovider	2.12.99

Supported QGIS version

• [ ] I'm running a supported QGIS version according to the roadmap.

New profile

• [X] I tried with a new QGIS profile

Additional context

Doesn't occur in 3.38.2 Grenoble so looks like a regression. Other rubberband-related issue here: #58813

[JuhoErvasti]

Okay, well with more testing this is seems very inconsistent. I can't get it to reproduce now, and not entirely sure what (if anything) I did differently when this behavior happened...

[agiudiceandrea]

I also cannot replicate the issue.

[JuhoErvasti]

Yes, sorry I might've been too hasty in writing this up. I haven't really noticed a pattern here, it just randomly happened when I was investigating this.

Not sure, maybe this issue should be closed unless/until I figure out when it actually occurs?