search

qgis / QGIS

QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)
https://qgis.org
GNU General Public License v2.0
10.67k stars 3.02k forks source link

Add feature map tool: Make highlight width always bigger than rubberband #59447

Closed JuhoErvasti closed 1 week ago

JuhoErvasti commented 2 weeks ago

There's no issue for this, since this addresses an oversight in #59424. I wasn't sure if one should be created in this case.

The highlight width was hardcoded to 2, which didn't take into account the user having potentially changed the rubberband width. Now the width will always be set as wider than the rubberband.

I also applied the width to polygons for consistency and in case the user has set an opaque rubberband.

JuhoErvasti commented 2 weeks ago

I wasn't sure if I should change this as well: the color of the highlight is currently set from the Identify tool's settings. This has been the case for point features for probably quite some time so I felt reticent to change it in case someone's using it.

But IMO it'd make more sense to use the rubberband's colors.

github-actions[bot] commented 2 weeks ago

🪟 Windows builds

Download Windows builds of this PR for testing. Debug symbols for this build are available here. (Built from commit 1560d1678cd524ee8172957796b3c7fb40a008e3)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing. (Built from commit 1560d1678cd524ee8172957796b3c7fb40a008e3)