search

qgis / qgis-feed

QGIS Welcome Page News Feed Backend
2 stars 7 forks source link

Error handling when editing and submitting new feed entry #55

Closed haubourg closed 8 months ago

haubourg commented 11 months ago

Hi @Xpirix I tested the new feed on friday to advertise a French QGIS event, and it is a wonderfull work. Kudos.

We noticed some minor glitches, here is the first one.

When editing one entry, an invalid entry is not easy to detect, and it is always possible to submit the form without any error message nor successful writing in the database. The preview form doesn't show any error, and we have to validate the entry to see some tiny orange warning about invalid forms

image

I suggest the warnings blocking editing are a bit bigger and red.
Ideally, they should appear dynamically when editing with client side logic.
expected this since I was looking at the "XXX words POWERED BY TINY" message, and thought this is where the error message would pop up.

If dynamic client side logic is too hard to implement, showing the warnings and errors could be done in the preview window.

Thanks !

Xpirix commented 11 months ago

Hello @haubourg , many thanks for the feedback. I appreciate it.

For this first glitch, please find a proposed PR at #59.

Best regards.