Fix non-standard widgets

[nyalldawson]

Qgis has some really nice dedicated widgets like the layer, field and projection pickers, but they aren't used everywhere.

It would be good if someone can sweep through all the dialogs and look for:

• custom field or layer pickers. The easiest way to identify these is if they are missing the layer/field type icons.

• non standard projection picker. The proper one should be the widget with the combo box with recent projection choices and the globe icon to open the full projection dialog.

[DelazJ]

@nyalldawson could you please precise with some images (or link to the icons?). I fail to visualize what you are talking about.

[nyalldawson]

@DelazJ sorry, mega delayed response.

Here's what I'm referring to. The standard layer picker includes an icon for the layer type (here it's a point geometry layer). The standard field picker shows icons for field types (the 'abc' icon here for a string field):

Non -standard widgets are usually missing these icons

The standard items also correctly sort layer names/field names.

Another way of identifying non-standard layer pickers is that the standard layer picker will show a tooltip identifying the layer path when you drop down the combo and hover over individual layer items.

The standard CRS selector should look like this:

It can be identified by the presence of items like "default CRS", "project CRS" and recently used CRSes in the drop down combo, and by the button which opens the full projection selector with the globe icon. Non-standard ones are things like just a label with a button to open the full selector dialog.

[DelazJ]

@nyalldawson I'd finally found what it was about. Another item I could add to this is the data-defined widget. And I think the Layer's properties --> Diagrams tab is a good candidate for this issue, using simple combobox for data-defined options. However, this seems to be more than simple replacement of widgets and I wonder if it's not already part of your grant proposal. Am I right?

[nyalldawson]

I'd finally found what it was about. Another item I could add to this is the data-defined widget. And I think the Layer's properties --> Diagrams tab is a good candidate for this issue, using simple combobox for data-defined options.

Yes - that's a perfect example.

However, this seems to be more than simple replacement of widgets and I wonder if it's not already part of your grant proposal. Am I right?

And yes - 100% correct. It's been addressed in this work and changed to the normal data defined widget which allows expressions/etc. Coming soon to master!

[DelazJ]

@nyalldawson I've made replacement of comboboxes into QgsFieldComboBox or QgsMapLayerComboBox (couldn't find any possible replacement for the crs selector :-( ) but given that there are some c++ things to change to have them totally active (e.g., QGIS crashes when the spatial query plugin is launched) , I keep them in my branch http://github.com/DelazJ/QGIS/tree/nonstandardicons. If someone wants to finish the work...

PS: I didn't touch the vector layer diagrams properties

[DelazJ]

Finally, I got one crs widget to replace :)