qgis / qgis4.0_api

Tracker for QGIS 4.0 API related issues and developer discussion
3 stars 1 forks source link

Remove QgsWkbTypes::Type::xxxx25D #107

Open rouault opened 4 years ago

rouault commented 4 years ago

I don't think we need those xxxx25D enumeration values that are duplicate of the xxxxZ variant. At least not in the public API (if we need them in a few spots, then just move them to a dedicated enumeration). This is a constant source of confusion & bugs (like https://github.com/qgis/QGIS/issues/33883)

nyalldawson commented 4 years ago

Does GDAL still use these?

rouault commented 4 years ago

Does GDAL still use these?

yes. But that could perhaps be isolated in QGIS to OGR-only code paths ? What is confusing in QGIS is the presence of both xxx25D and xxxZ.

nyalldawson commented 4 years ago

Fair enough!