search

qgis / qgis4.0_api

Tracker for QGIS 4.0 API related issues and developer discussion
3 stars 1 forks source link

Make provider name resolution case insensitive #109

Open nyalldawson opened 4 years ago

nyalldawson commented 4 years ago

We currently have a gross mix of provider names in upper/lower case. E.g. "WFS" vs "wms". It's confusing even for experienced developers!

We should either unify the case of all the names (more porting work required for 4.0 plugin upgrades), or just make the name resolution case insensitive (possibly we could even do this before 4.0 -- comments welcome!).

I can't see that there'd ever be a valid use case for two different providers with the same name but different casing...

NathanW2 commented 4 years ago

I would say it can be done now, can't see it breaking anything...

On Fri, Feb 28, 2020 at 9:06 AM Nyall Dawson notifications@github.com wrote:

We currently have a gross mix of provider names in upper/lower case. E.g. "WFS" vs "wms". It's confusing even for experienced developers!

We should either unify the case of all the names (more porting work required for 4.0 plugin upgrades), or just make the name resolution case insensitive (possibly we could even do this before 4.0 -- comments welcome!).

I can't see that there'd ever be a valid use case for two different providers with the same name but different casing...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/qgis/qgis4.0_api/issues/109?email_source=notifications&email_token=AAC5FXHYJGZ33VGSDQTW333RFBBQXA5CNFSM4K5FEW2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQ6MQMQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5FXFWRH4VSPQM35FBWFDRFBBQXANCNFSM4K5FEW2A .

m-kuhn commented 4 years ago

Yes, do that now unifying capitalization in 4.0 sounds good.

elpaso commented 4 years ago

Yes, please, this bugged me a lot in the past (now I think I memorized the uppercase ones).