search

qgis / qgis4.0_api

Tracker for QGIS 4.0 API related issues and developer discussion
3 stars 1 forks source link

Rename QgsPanelWidget::panelAccepted to panelDismissed #116

Open nyalldawson opened 3 years ago

nyalldawson commented 3 years ago

"panelAccepted" falsely conveys the impression that the panel has been "accept". Yet it's actually used to indicate that the panel has been dismissed, as all changes will have already been accepted by the live "change" signals. This results in awkward looking (but correct) code like:

  connect( mWidget, &QgsPanelWidget::panelAccepted, this, &QDialog::reject );

which would be much clearer if the signal were renamed to "panelDismissed":

  connect( mWidget, &QgsPanelWidget::panelDismissed, this, &QDialog::reject );