Make QgsVectorDataProvider::Capability use QFlags

qgis / qgis4.0_api

Tracker for QGIS 4.0 API related issues and developer discussion

3 stars 1 forks source link

Make QgsVectorDataProvider::Capability use QFlags #24

Closed nyalldawson closed 7 years ago

nyalldawson commented 8 years ago

Instead of returning an int from QgsVectorDataProvider::capabilities(), it should instead return a Capabilities QFlags class for type safety/ease of use.

m-kuhn commented 8 years ago

Can we not already do that now with a separate method?

I would prefer renaming it to another name anyway, using the same name with a different semantics may result in strange results which are hard to debug, no?

nyalldawson commented 8 years ago

Wouldn't adding a separate method for this break 3rd party providers?

m-kuhn commented 8 years ago

Just realized that it wouldn't actually change the semantics. Forget my comment.

nyalldawson commented 7 years ago

Implemented in https://github.com/qgis/QGIS/commit/58856fe82f14e1d3b500584116349a53f62e617d