qgis / qwc2-demo-app

QWC2 demo application
Other
241 stars 154 forks source link

Attribution of background layer(s) not visible #487

Closed mhaelsig closed 11 months ago

mhaelsig commented 11 months ago

Hi, although 'attribute' and 'attributeUrl' are set, these attributions are not shown, at least when switching the background layer. Even the qwc2-demo-app always shows the attribution 'Demo attribution', although the corresponding themes.json contains specific attributions for e.g. the OSM background layer. Here I am lost - I do not like fights with legal ;-)

manisandro commented 11 months ago

Can you attach your themes.json?

mhaelsig commented 11 months ago

themesConfig.rwpl.json

Although the same behaviour can be seen with [qwc2-demo](http://qwc2.sourcepole.ch/ ??

manisandro commented 11 months ago

Are you using a current version of QWC2? I cannot reproduce it with master.

mhaelsig commented 11 months ago

Yes, I am using the current version.

Looking at the current version of http://qwc2.sourcepole.ch/ in the lower right corner Screenshot_20231017_173707 I cannot find the OSM attribution, although given as parameter in themesConfig.json:

Screenshot_20231017_174152 Probably the themes attribution (here: 'Demo attribution') is hiding the background layer attribution. If I omit the themes attribution (in my application), there is also no OSM attribution: Screenshot_20231017_175604 In which situation is the background layer attribution visible?

manisandro commented 11 months ago

The OSM attribution is there (although structured slightly differently):

image

mhaelsig commented 11 months ago

Thank you for your quick response. I don't need to know where and how to specify the background layer attribution, but I would like to know, where the qwc2 viewer places this attribution. Therefore, the two screenshots above. The issue is: the end user cannot see this background layer attribution. In the example above: 'OpenStreetMap contributors'.

manisandro commented 11 months ago

Sorry I read too fast and though that you were missing the attribution in the generated themes.json. In any event, qwc2.sourcepole.ch had showThemeCopyrightOnly: true in config.json (I've now set it to false), you probably have the same setting in your config.json.

mhaelsig commented 11 months ago

Thank you 😁 - this solved the issue.