qgis2web / qgis2web

QGIS plugin to export your project to an OpenLayers or Leaflet webmap. No server-side software required.
https://plugins.qgis.org/plugins/qgis2web/
GNU General Public License v2.0
591 stars 156 forks source link

Learning how to contribute #1057

Closed lecneri closed 6 months ago

lecneri commented 7 months ago

Hello,

A friend want to contribute with the project because he faced some hardtime accessing mobile, but not sure how to quite do it. And asked me to help. He downloaded dist version 3.20.1 of openlayers.org and replaced ol.js and ol.css of resources folder. Because of it, he had to alter resources/ol-layerswitcher.js at line 300 FROM var descendantVisibility = group.getLayersArray().map(function (l) { To var descendantVisibility = group.getLayers().getArray().map(function (l) { We'd like to know how can we submit and contribute to this project doing this modification, and doing a PR

andreaordonselli commented 7 months ago

Thank you for wanting to contribute to the project. The guide to create a pull request is officially explained by github here https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

In any case it doesn't seem like a good idea to replace the current version of openlayers with an older one. With this commit openlayers is at version 6.4.3: https://github.com/tomchadwin/qgis2web/commit/533eaba21bf6f3329f577ff083a2beae740a3f96

What we need to do is go from version 6 to version 9, not go back to 3 Thank you