search

qgisinspiretools / qgis-wfs20-client-plugin

QGIS Plugin for OGC Web Feature Service 2.0.0
11 stars 8 forks source link

Crash opening features with lots of xlink:href #19

Closed JPPauly closed 3 years ago

JPPauly commented 4 years ago

Hello, on loading features with lots of xlink:href elements with the resolve option activated, f.e. from INSPIRE AU.AdministrativeUnits, QGIS3 crashes.

Example-service that leads to crashes on loading AdministrativeUnits: https://www.geodaten-mv.de/dienste/inspire_au_atkis_bdlm_download

I found a solution by changing the line 1010 in wfsclientdialog.py to: gdal.SetConfigOption('GML_SKIP_RESOLVE_ELEMS', 'HUGE')

ejn commented 4 years ago

Thanks for the report. Looking at https://gdal.org/drivers/vector/gml.html#gml-xlink-resolving then setting GML_SKIP_RESOLVE_ELEMS to HUGE should work in all cases.

I wonder whether there any disadvantages to it? I guess a slight overhead in saving resolved objects to DB rather than keeping them in memory, but any others?

Maybe it would be better to allow the user to choose between ALL, HUGE AND NONE in the configuration dialog in case there are some special cases where one or the other is necessary?

ejn commented 4 years ago

It seems that there are no disadvantages to using HUGE (source), so I'll just change it as you suggest.

JPPauly commented 3 years ago

Thank you for fixing the issue.

Are there any plans to deploy those fixes to the QGIS Plugin repository's version of the plugin? That would make rollout easier in our organisation.

ejn commented 3 years ago

@JPPauly Thanks for the feedback. To be honest I'd completely forgotten that this hadn't been done - I'll see to it, that the repo version gets updated and close this ticket once it's done.

ejn commented 3 years ago

Plugin version 0.9.10 is now published and approved in the QGIS Plugins repository.