search

qgisred / QGISRed

GNU General Public License v2.0
23 stars 8 forks source link

Import .inp : Demands without pattern #76

Closed hyperprogram2 closed 2 years ago

hyperprogram2 commented 2 years ago

Hello,

When importing an INP file from Epanet into Qgisred, some jointures have a demand value but no associated demand pattern. For junctions with several demand catgeroies in Epanet, some demands patterns are also missing.

for example in the attached files : In Epanet INP : Junction J146783 has '067' as demand Pattern image

but after importing in QgisRed, the demand pattern disapeared for J146783 whereas the Demand Pattern exist in Qgisred image image

For Jointure J153255 : 2 Demand Pattern in Epanet but 0 associated in Qgisred In Epanet : image In QGisred : image image

Example file : TEST_export_demands.zip

I use Qgis 3.16.1 and Qgisred 0.14.3

Regards

neslerel commented 2 years ago

Thanks @hyperprogram2 for reporting it. I'll ckeck it!

neslerel commented 2 years ago

Wow! I had problems to find the issue. It was saving the data in the shapefile... The demand value has more digits than allowed and it failed to save the other properties... It is fixed! Thanks @hyperprogram2

hyperprogram2 commented 2 years ago

Nice When will you release the corrected version ?

neslerel commented 2 years ago

I would like to fix the issue with the interpolation of elevations before releasing a beta version.

neslerel commented 2 years ago

Hi @hyperprogram2,

I fixed the problem with the interpolation of elevations.

In this link you can download an unofficial version (0.14.4) to test it. http://www.redhisp.webs.upv.es/files/QGISRed/QGISRed_v0.14.4.zip

To use it, you have to:

  1. Uninstall the QGISRed plugin from the QGis plugin manager.
  2. Close QGis
  3. Go to Windows Applications and Features and uninstall the program called QGISRed (I guess version 1.0.14.0 or 1.0.14.3)).
  4. Open QGis and go to the plugin manager.
  5. Install from file (with the zip downloaded from the previous link)
  6. When using it, it will ask to install the new dependencies.

Please, confirm if all the issues you opened are fixed and if yes, please close them. Thanks!!

hyperprogram2 commented 2 years ago

Hello, I tried the 0.14.4 version with the same input data (TEST_export_demands.zip) but I still do not have value in IDPattDem for some Junctions (ex: J146783) or demands (ex:J149817)

Regards

neslerel commented 2 years ago

Hi @hyperprogram2,

Are you sure? I tested it again and I can see the IdPattern and the 2 demands of the junctions you mentioned. Dif you follow all the steps? Can you review if you have more than one QGISRed version on Windows Applications and Features?

Maybe you have to restart your computer before install the new version (and after unistall the plugin and the QGISRed program)... I don't know... Only just in case it fix the problem...

I'm going to test it in other computer...

hyperprogram2 commented 2 years ago

Hi, I confirm. I follow the steps. I restart severals times. 0.14.4 version is installed after uninstalling previous version (several try)

Bugs on timestep results are well resolved by 0.14.4 but issues remain for elevation interpolation (with comma as decimal separator) and Idpattern import

neslerel commented 2 years ago

I tested in other computer and, at least, the issue with demands (J146783 and J149817) is fixed. I don't know what happen with your computer... I hope that when we'll release the next official version (0.15) it'll work fine in your computer.

Thanks for all your feedback!

hyperprogram2 commented 2 years ago

I've found I had two Qgisred (0.14.3 and 0.14.4) in Windows app.

After uninstall and intall, it's OK : Pattern Import and Interpolation are OK

Thank you

neslerel commented 2 years ago

Perfect, I am very happy!