search

qgustavor / mega

Unofficial JavaScript SDK for MEGA
https://mega.js.org/
MIT License
161 stars 43 forks source link

Release - v1.2.0 #141

Closed qgustavor closed 1 year ago

qgustavor commented 1 year ago

Release v1.2.0

Changelog

Minor Changes

Fix verify (@qgustavor)

It was requiring .resume(), which was not intended nor documented. .verify() does not return the input anymore. The idea was fixing the need to a .resume() but it didn't work. I will not reverse that, at least I hope it reduces memory usage.

Update PR template (@qgustavor)

Add support to 2FA (@qgustavor)

My account uses 2FA, so it need it implemented. Also updated error codes.

Bump json5 from 1.0.1 to 1.0.2 (@dependabot[bot])

Bumps json5 from 1.0.1 to 1.0.2. Release notes. Sourced from json5's releases. v1.0.2.

qgustavor commented 1 year ago

Can someone test this?

github-advanced-security[bot] commented 1 year ago

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

qgustavor commented 1 year ago

Someone commented about logging in using an API key. I did a quick look in my MEGA account and found no reference to a API key. The recovery key, from what I understand, cannot be used to login, just to decrypt account data, so support can allow people to bypass the login and decrypt data as long they have this key, but this key cannot be used to login. This the recovery key is not an API key. If there is really an API key someone can send a pull request implementing its logic, I could not find anything about it.

qgustavor commented 1 year ago

The verify fix did nothing. Is better to just add a note to the documentation about that issue. I tested the rest using megajs-cli, which I will soon update with support to 2FA. I hope pr-release uses the correct version.

qgustavor commented 1 year ago

No, it didn't release the correct version. The documentation says " So if you want to override the generated version, just manually update the release PR title to be a normal non-semver prerelease and merge." I updated the release PR title AND IT STILL USED THE WRONG VERSION. Great.