search

qgustavor / mega

Unofficial JavaScript SDK for MEGA
https://mega.js.org/
MIT License
161 stars 43 forks source link

Release - v1.2.0 #182

Closed qgustavor closed 7 months ago

qgustavor commented 8 months ago

Release v1.2.0

Changelog

Minor Changes

Find and fetch (@qgustavor)

Implement find, search and navigate functions, and fix fetch related issues.

Patch Changes

Add test for providing a stream as an input (@qgustavor)

No, that's not because of the guy who doesn't read things, that's because I noticed there was not a test for that.

AliAryanTech commented 8 months ago

require() of ES Module /app/node_modules/megajs/node_modules/node-fetch/src/index.js from /app/node_modules/megajs/dist/main.node-cjs.js not supported. Instead change the require of index.js in /app/node_modules/megajs/dist/main.node-cjs.js to a dynamic import() which is available in all CommonJS modules.

In latest version, I'd use example code

qgustavor commented 8 months ago

I was kinda expecting that, that's why I ran the tests, I just didn't expected that the tests would not detect that. Please, send a pull request fixing it or wait until it bothers it me so much that I fix that myself. Which can take a lot of time since I'm delayed for work at the moment and I don't even know how I could find time to answer this comment... 😑

qgustavor commented 8 months ago

Other option, I forgot to comment, is downgrading node-fetch back to the v2 branch which still support require(). That's why node-fetch was in v2.

AliAryanTech commented 8 months ago

Other option, I forgot to comment, is downgrading node-fetch back to the v2 branch which still support require(). That's why node-fetch was in v2.

alright thanks

qgustavor commented 7 months ago

Ok, I just need to update documentation now.