search

qiangyicheng / flory

Python package for finding coexisting phases in multicomponent mixtures.
https://flory.readthedocs.io/en/latest/
MIT License
4 stars 1 forks source link

Added `get_uniform_random_composition` function #10

Closed david-zwicker closed 2 months ago

david-zwicker commented 2 months ago

Additionall ran ruff check --fix to fix some style issues

david-zwicker commented 2 months ago

Looks like I messed up the branch where I did the edits. These changes do not seem to be based on main. Do you know how to change this?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
Tests 87.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
flory/common/phases.py 97.33% <100.00%> (ø)
flory/common/utilities.py 94.73% <100.00%> (ø)
qiangyicheng commented 2 months ago

I thinks it's fine. After we merge the dev_paper branch, we can merge main into this branch. Currently dev_paper branch is just ahead of main.

david-zwicker commented 2 months ago

Good – I should still be a bit more careful with this

david-zwicker commented 2 months ago

Ok, rebase did not do what I thought it would do... At least this branch now does not have any conflicts with the main branch anymore...