feat: add convergence info in results

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
flory/common/phases.py	96.77%	1 Missing :warning:

Flag	Coverage Δ
Tests	`87.91% <97.36%> (+0.77%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
flory/__init__.py	`100.00% <100.00%> (ø)`
flory/common/__init__.py	`100.00% <100.00%> (ø)`
flory/common/utilities.py	`94.73% <ø> (ø)`
flory/entropy/__init__.py	`100.00% <100.00%> (ø)`
flory/interaction/flory_huggins_block.py	`72.97% <ø> (ø)`
flory/mcmp/finder.py	`84.97% <100.00%> (+0.51%)`	:arrow_up:
flory/shortcut.py	`100.00% <100.00%> (ø)`
flory/common/phases.py	`96.92% <96.77%> (+13.99%)`	:arrow_up:

david-zwicker commented 2 months ago

I made some minor suggestions – let's discuss them when we find the time.

qiangyicheng commented 2 months ago

Sure! I actually like the changes quite a lot. It keeps the Finder class decoupled.

david-zwicker commented 2 months ago

That was the idea :)

david-zwicker commented 2 months ago

Can we merge this PR or are there still open problems?