[JOSS review] Dependency issue Matplotlib

qiangyicheng / flory

Python package for finding coexisting phases in multicomponent mixtures.

https://flory.readthedocs.io/en/latest/

MIT License

4 stars 1 forks source link

[JOSS review] Dependency issue Matplotlib #19

Closed SunyongKwon closed 1 day ago

SunyongKwon commented 1 month ago

A few examples require the Matplotlib package for visualization. Please consider adding Matplotlib in the installation requirement, so that the users run examples without facing issues.

qiangyicheng commented 3 days ago

Thank you for the helpful suggestion. We did not include Matplotlib since it is bulky and not directly referenced by the main functionality of our package. Therefore we chose to treat it as an optional dependency that can be installed by a dev option. We have revised README.md to clarify this, and provided options example, test and doc to choose among different groups of optional dependencies.