search

qianz-z / pe

0 stars 0 forks source link

Incorrect notation of CommandAddProperty #12

Open qianz-z opened 2 years ago

qianz-z commented 2 years ago

There seems to be crosses 'X' around the borders of CommandAddProperty class, and this is not compliant with the notation covered in the module. Other than that, the class diagram seems to be correct! Good job! image.png

nus-pe-script commented 2 years ago

Team's Response

This diagram is actually a Architectural Diagram used to show the relationship between different components. Therefore, I don't think there is a convention or notation to it. The crosses 'X' is because it's being selected and it's not being drawn.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for explaining that the notation means that it is being selected. I do think it will be great if the DG lets the readers know why there are crosses around the CommandAddProperty class, and I was personally confused as to why there are those additional crosses on it. Therefore, I think it will hinder some readers as the DG did not clarify the presence of those crosses as well.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]