hw10 ready for grading - Githubissues

qiaoyuet / STAT545-hw-Tang-Qiaoyue

0 stars 1 forks source link

hw10 ready for grading #10

Open qiaoyuet opened 6 years ago

qiaoyuet commented 6 years ago

Link to md file

Link to the cleaned dataframe

SHA: e23a87b

swynes commented 6 years ago

Peer Review

Hi there,

Nice job on homework ten! Good for you going the more ambitious route and working without an API!

The dataframe that you created looks clean and usable.
Your code is well annotated so it's easy to understand what's going on.
Good, basic analysis of your data with boxplots and histograms to show that the dataframe is ready for use
I ran your code and it all seemed to work. You're right that the mutate function runs very slowly but I couldn't think of a better work around.

Congrats on finishing the course!

Seth

marbazua commented 6 years ago

Hi @qiaoyuet

Good usage of css selectors to scrap data on your assignment! You succesfully created a dataframe from data from the web. I enjoyed reviewing your assignment, the code ran without issues. I strugled with this assignment so I don't have any suggestion for improvement. I think that your assignment 10 is a nice compilation of several topics we learned trough this course. You used stringr to manipulate strings, mutate, purrr, gglot, and write to a csv. Good job!!

Best,

Mar

ksedivyhaley commented 6 years ago

Method Chosen: scrape Gets data from web: Yes Clean and tidy data frame: Yes Basic Data Exploration: Yes Report/Reflection: Yes

Comments:

Solid execution, clear process.

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.