qiaoyuet / STAT545-hw-Tang-Qiaoyue

0 stars 1 forks source link

hw06 ready for grading #6

Open qiaoyuet opened 7 years ago

qiaoyuet commented 7 years ago

IMPORTANT: Instruction for viewing this homework

Since in Part 1 of this homework I used str_view() to see the matches of strings and it is a html widget that cannot be displayed in github properly. Try the following to view it:

SHA: bec96fa

qiaoyuet commented 7 years ago

Link to hw05 folder: https://github.com/qiaoyuet/STAT545-hw-Tang-Qiaoyue/tree/master/hw06

MD File of hw06: https://github.com/qiaoyuet/STAT545-hw-Tang-Qiaoyue/blob/master/hw06/hw06.md

RMD File of hw06: https://github.com/qiaoyuet/STAT545-hw-Tang-Qiaoyue/blob/master/hw06/hw06.Rmd

HTML File of hw06: https://github.com/qiaoyuet/STAT545-hw-Tang-Qiaoyue/blob/master/hw06/hw06.html

ilgan commented 7 years ago

@qiaoyuet Good work! Part one: more than 20 exercises, and it takes some time! Good work. Functions that you wrote are quite useful also showed understanding o the linear regression and its usage in practical problems.

Notes:

Overall very nice work!

farihakhan commented 7 years ago

Good work on completing assignment 6!

Part 1: Nice work on completing the exercised from the Strings chapter. I also did this part and it took me a really long time to complete. I noticed that your str_view() output isn't formatted in github properly; I also had this issue and did not know how to solve it. I later began using a different str function.

Part 2: It's nice that you tried writing more than one function in this section. I would try naming your functions more descriptively, that way variables that hold functions don't get confused with variables that hold data. Impressive use of nesting a loop within your function as well. It would be nice to see what the output of the Bisection Algorithm algorithm gave though.

Part 3: Good work with completing more than 2 sections of the assignment. The presentation might have been cleaner if you had separated section 1 from the function and list sections, this section of your assignment seems to be more intended. You did a nice job covering different abilities of your nested list - using some additional plots and figuring could have added to this.

Overall, good job!

ksedivyhaley commented 7 years ago

At least two topics: Yes (character data, functions, nested data frame) Character data (13 sections): Yes Functions: OK Nested data frame: Yes Reflection: Yes

Comments:

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.