qibogang / qibogang.github.io

The gang site :)
https://qibogang.github.io
0 stars 0 forks source link

Responsive tutorial container #20

Open MatteoRobbiati opened 1 year ago

MatteoRobbiati commented 1 year ago

Playing a bit with the site It is clear that, using a small screen device, the tutorials display is horrible. I will open a PR to fix this: the goal is to find the container we need to modify (the strange fact is that it is the only kind of page which not fit the screen, also using the same container of the others).

alecandido commented 1 year ago

This is mainly required for reading on phones. Relevant, but there is no priority at the moment.

MatteoRobbiati commented 1 year ago

I have solved this in the first commit of #21. I am sorry to have mixed two themes in the same PR. Do you think I can open a new PR for fixing in a super fast way this problem @AleCandido ? Then I can remove that commit from #21.

alecandido commented 1 year ago

This can be a good option.

Just:

alecandido commented 1 year ago

No need to remove the commit from #21, keep it. Eventually, it will just be based on the new master, containing that commit as well

MatteoRobbiati commented 1 year ago

This can be a good option.

Just:

  • checkout that commit in git (git checkout)
  • branch off (git switch -c)
  • push the new branch
  • make a PR based on the new branch

Thank you for this, it is a useful way to proceed.