search

qiboteam / boostvqe

Using DBI top boost VQE optimization
3 stars 1 forks source link

Code refactor: second round #63

Open andrea-pasquale opened 2 months ago

andrea-pasquale commented 2 months ago

Further simplification of the code. It should be ready to review now.

marekgluza commented 2 months ago

No action required, comment for the future: for consistency the test function snippet was removed (which is ok) https://github.com/qiboteam/boostvqe/blob/e108ee4be22acf421e40c0c94da787015a9a9093/src/boostvqe/compiling_XXZ.py#L161-L164

In the future we may keep that function in this form for pytest because keeping that phase in this form is crucial for getting a converging norm

andrea-pasquale commented 2 months ago

@andrea-pasquale while running checks for proceedings @Sam-XiaoyueLi found probably a bug in kwargs of https://github.com/qiboteam/boostvqe/blob/e5d458d5d591530f24ce87510d90608991c640da/src/boostvqe/models/dbi/double_bracket_evolution_oracles.py#L274C1-L295C10 she'll post an issue in a bit

https://github.com/qiboteam/boostvqe/issues/68#issuecomment-2227903814

marekgluza commented 2 months ago

thanks a lot @andrea-pasquale

@MatteoRobbiati if you run anything then keep the fixes in this PR in mind :)