qiboteam / qibo-client

Qibo remote connection client.
https://qibo.science
Apache License 2.0
1 stars 0 forks source link

Raise warning instead of error when qibo version mismatch #26

Closed marcorossi5 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9ed7542) to head (4a5eac0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 4 6 +2 Lines 119 124 +5 ========================================= + Hits 119 124 +5 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibo-client/pull/26/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibo-client/pull/26/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scarrazza commented 4 months ago

Thanks @marcorossi5, could you please fix coverage?

marcorossi5 commented 4 months ago

It's done, hit 100% coverage. Do we have to make a new release when merging this?

scarrazza commented 4 months ago

Thanks @marcorossi5, yes I will do the release if you don't plan to add other features, please let me know.

marcorossi5 commented 4 months ago

Not for now. Do you want me to update "0.0.3" -> "0.0.4" with a new commit in this branch?

scarrazza commented 4 months ago

No, thanks, the next release is 0.0.3.

marcorossi5 commented 4 months ago

ok, fine. It's ready for me