Add unit tests to client

qiboteam / qibo-client

Qibo remote connection client.

https://qibo.science

Apache License 2.0

2 stars 1 forks source link

Add unit tests to client #9

Closed marcorossi5 closed 9 months ago

marcorossi5 commented 9 months ago

@scarrazza, I've added the workflow to publish on pypi. We should put the secret in the PYPI_TOKEN variable. I'm afraid I do not have permissions to do that.

After that, I think we can merge

scarrazza commented 9 months ago

@marcorossi5 could you please use the approach in qibo? We have a repository with workflows, please double check.

marcorossi5 commented 9 months ago

@scarrazza, it should be done now, but the workflow is failing at the codecov stage due to a missing token. Do we have to update the repo secrets for that?

codecov[bot] commented 9 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

scarrazza commented 9 months ago

Thanks @marcorossi5, now this repo is public and I have activated codecov and precommit.

scarrazza commented 9 months ago

@marcorossi5 just another couple of requests:

could you please replace in all places TiiQ with TII-QRC?
I think it would be useful to include some technical docs explaining how to use this library and the content of the library. For example a simple sphinx page, with installation instructions, a short tutorial and the api reference should be sufficient. Could you please grab the setup in qibo* and try to port here, maybe in another PR?

marcorossi5 commented 9 months ago

Let me replace TiiQ with TII-QRC. Then, if you agree, we can merge and open a new PR to address the second point.

Do you want to keep TIIProvider as the client class name? or do you want me to change it?

scarrazza commented 9 months ago

Great, thanks. I think we can keep TIIProvider for now.

marcorossi5 commented 9 months ago

What about the package name? qibo_tii_provider still works?

scarrazza commented 9 months ago

Let me think but meanwhile let's keep as it is. I just prefer to avoid using TiiQ in the docs.