mho291
commented
5 months ago Hi @BrunoLiegiBastonLiegi , so sorry to trouble you.
I've added a new gate called Phase RX gate inside qibo/gates/gates.py with its pytest function in qibo/tests/test_gates_gates.py but am encountering some errors.
In qibo/gates/gates.py, I have this:
class PRx(ParametrizedGate):
"""Phase Rx gate.
Corresponds to the following unitary matrix
.. math::
\\begin{pmatrix}
\\cos{(\\theta / 2)} & -i e^{-i \\phi} \\sin{(\\theta / 2)} \\
-i e^{i \\phi} \\sin{(\\theta / 2)} & \\cos{(\\theta / 2)}
\\end{pmatrix}
Args:
theta (float): The first angle of the gate in radians or expression representation.
phi (float): The second angle of the gate in radians or expression representation.
"""
def __init__(self, q, theta, phi, trainable=True):
super().__init__(trainable)
self.name = "prx"
self.draw_label = "prx"
self.target_qubits = (q,)
self.unitary = True
if theta is None:
raise_error(
ValueError,
f"Theta is not defined.",
)
if phi is None:
raise_error(
ValueError,
f"Phi is not defined.",
)
self.parameter_names = ["theta", "phi"]
self.theta = theta
self.phi = phi
self.nparams = 2
self.init_args = [q]
self.init_kwargs = {
"theta": theta,
"phi": phi,
"trainable": trainable,
}
@property
def qasm_label(self):
return "prx"
def _dagger(self) -> "Gate":
theta = -self.theta
phi = self.phi
return self.__class__(
self.target_qubits[0], theta, phi
) # pylint: disable=E1130and inside qibo/tests/test_gates_gates.py I have added this function to test:
def test_prx(backend):
phi = 0.24
theta = 0.52
final_state = apply_gates(
backend, [gates.H(0), gates.PRx(0, theta=theta, phi=phi)], nqubits=1
)
cos = np.cos(theta / 2)
sin = np.sin(theta / 2)
exponent1 = -1.0j * np.exp(-1.0j * phi)
exponent2 = -1.0j * np.exp(1.0j * phi)
gate = np.array([[cos, exponent1 * sin], [exponent2 * sin, cos]])
target_state = gate.dot(np.ones(2)) / np.sqrt(2.0)
backend.assert_allclose(final_state, target_state)
assert gates.PRx(0, phi=phi, theta=theta).qasm_label == "prx"
assert not gates.PRx(0, phi=phi, theta=theta).clifford
assert gates.PRx(0, phi=phi, theta=theta).unitary
I have also added the matrix form of the Phase RX gate inside qibo/backends/npmatrices.py:
def PRx(self, theta, phi):
cos = self.np.cos(theta / 2)
sin = self.np.sin(theta / 2)
exponent1 = -1.0j * self.np.exp(-1.0j * phi)
exponent2 = -1.0j * self.np.exp(1.0j * phi)
return self._cast(
[[cos, exponent1 * sin], [exponent2 * sin, cos]], dtype=self.dtype
)However, I'm encountering some errors when running pytests on my local laptop. This is the failure message:
=========== FAILURES ===========
_____________ test_prx[numpy] _____________
backend = numpy
def test_prx(backend):
phi = 0.24
theta = 0.52
final_state = apply_gates(
> backend, [gates.H(0), gates.PRx(0, theta=theta, phi=phi)], nqubits=1
)
E AttributeError: module 'qibo.gates' has no attribute 'PRx'
test_gates_gates.py:1068: AttributeError
I've tried to resolve it as best as I can to no avail. Could I ask for help / advice on how to get this to work? Thank you!
BrunoLiegiBastonLiegi
renatomello
codecov[bot]
Checklist: