qiboteam / qibo

A framework for quantum computing
https://qibo.science
Apache License 2.0
287 stars 58 forks source link

`random_clifford` casting qubits to python int #1336

Closed scarrazza closed 4 months ago

scarrazza commented 4 months ago

Related to the bug observed in https://github.com/qiboteam/qibo-client/issues/39. It looks like the qubit numbers are stored as numpy.int64 instead of python int, therefore serialization with json does not work from the qibo-client side. Could you please confirm this patch is acceptable?

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.82%. Comparing base (a61f9f7) to head (bbe925f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1336 +/- ## ======================================= Coverage 99.82% 99.82% ======================================= Files 72 72 Lines 10560 10560 ======================================= Hits 10541 10541 Misses 19 19 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibo/pull/1336/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibo/pull/1336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `99.82% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.