Open MatteoRobbiati opened 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.82%. Comparing base (
ad50a20
) to head (750a510
).:exclamation: Current head 750a510 differs from pull request most recent head 72eea4b
Please upload reports for the commit 72eea4b to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@BrunoLiegiBastonLiegi @Edoardo-Pedicillo now tests are passing.
@BrunoLiegiBastonLiegi I'd just go for the uniform scheme, no need to make Qiboml different from the other providers.
We should keep a single instruction, just for "tensorflow"
, that will check explicitly for it, and, in case, replace the backend with "qiboml"
, and the platform with "tensorflow"
.
This should be just a transition device, until we decide to break for good (thus, we'll open an issue about, and schedule for removal).
Moreover, I'd even drop all the QIBO_NON_NATIVE_BACKENDS
specification, just rely on the package name (as we're already doing).
If the package is not available, we could catch the error and re-raise, hinting that is not installed, or misspelled (that could even be non-existing).
This will allow future backend providers to avoid at all the need of editing qibo
source.
Checklist: