Closed alecandido closed 4 months ago
@mho291 I started adding a minimal test that reproduces your issue.
I'm now going to add the patch that should make that test passing. Whenever you have time, confirm that the test is close enough to what you expect (then I will also ask to check the full fix).
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.84%. Comparing base (
98a310a
) to head (b51190c
). Report is 26 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For the time being, it's a quick patch (plus some docstrings beautifications).
I wanted to refactor a bit more the function. But I took a look at the rest of the module, and there are many things to refactor. So, it's not worth to do it now, better to allocate some time and do it consistently.
Thanks @alecandido ! I have checked the code and verified it works. Will approve the changes.
Fixes #1383
Checklist: