search

qiboteam / qibo

A framework for quantum computing
https://qibo.science
Apache License 2.0
287 stars 58 forks source link

Variable not defined in `mpldrawer` #1437

Closed renatomello closed 2 weeks ago

renatomello commented 3 weeks ago

@MatteoRobbiati @sergiomtzlosa

PR #1370 introduced the new ui module to master. There is a helper function in the module that is raising a lint error due to an undefined variable. The specific line is this one. This is preventing tests from passing, e.g. https://github.com/qiboteam/qibo/actions/runs/10715691273/job/29711648870

MatteoRobbiati commented 3 weeks ago

Thanks for spotting this! @sergiomtzlosa, should we pass the circuit as an argument so that we keep that line or do you think we can do that in a different way?

sergiomtzlosa commented 3 weeks ago

sorry @renatomello and @MatteoRobbiati ! I did not spot this, I just submit a commit to fix this bug

alecandido commented 3 weeks ago

Yeah, unfortunately we didn't notice because the CI was not running, since the PR came from a fork.

However, this should not happen for new PRs, even from forks. If that's not the case, please report it to me or @scarrazza

MatteoRobbiati commented 3 weeks ago

sorry @renatomello and @MatteoRobbiati ! I did not spot this, I just submit a commit to fix this bug

No problem. Are you going to open a PR for this?

sergiomtzlosa commented 3 weeks ago

yes! here is the pull request https://github.com/qiboteam/qibo/pull/1438