qiboteam / qibo

A framework for quantum computing
https://qibo.science
Apache License 2.0
287 stars 58 forks source link

Fixes related to MPL drawer #1444

Closed MatteoRobbiati closed 2 weeks ago

MatteoRobbiati commented 2 weeks ago

Thanks @sergiomtzlosa for the fixes already done in #1438. We can keep that PR to solve the coverage problems and use this one to fix asap the errors.

Checklist:

sergiomtzlosa commented 2 weeks ago

great @MatteoRobbiati just let me know to get hands on

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 97.10%. Comparing base (7864590) to head (bf626f5). Report is 118 commits behind head on master.

Files with missing lines Patch % Lines
src/qibo/ui/mpldrawer.py 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1444 +/- ## ========================================== - Coverage 99.94% 97.10% -2.84% ========================================== Files 78 81 +3 Lines 11324 11653 +329 ========================================== - Hits 11318 11316 -2 - Misses 6 337 +331 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibo/pull/1444/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibo/pull/1444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `97.10% <0.00%> (-2.84%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

renatomello commented 2 weeks ago

@MatteoRobbiati I can't merge it since coverage is not passing. Idk if you have the right level of authorization for that or if it's just @scarrazza

scarrazza commented 2 weeks ago

Coverage is failing, correct?

renatomello commented 2 weeks ago

Coverage is failing, correct?

If I understood correctly, coverage fix is being implemented in #1438

sergiomtzlosa commented 2 weeks ago

Coverage is failing, correct?

If I understood correctly, coverage fix is being implemented in #1438

Yes, you are right

MatteoRobbiati commented 2 weeks ago

Yes, correct. With this we fix errors and with the other one we can fix coverage. If you prefer, we can fix everything there, but that will take a bit more time.

renatomello commented 2 weeks ago

Yes, correct. With this we fix errors and with the other one we can fix coverage. If you prefer, we can fix everything there, but that will take a bit more time.

I'd prefer if this is merged as is, so other PRs can move forward while #1438 fixes the coverage.

scarrazza commented 2 weeks ago

I agree, thanks.