Closed MatteoRobbiati closed 2 weeks ago
great @MatteoRobbiati just let me know to get hands on
Attention: Patch coverage is 0%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 97.10%. Comparing base (
7864590
) to head (bf626f5
). Report is 118 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/qibo/ui/mpldrawer.py | 0.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@MatteoRobbiati I can't merge it since coverage is not passing. Idk if you have the right level of authorization for that or if it's just @scarrazza
Coverage is failing, correct?
Coverage is failing, correct?
If I understood correctly, coverage fix is being implemented in #1438
Coverage is failing, correct?
If I understood correctly, coverage fix is being implemented in #1438
Yes, you are right
Yes, correct. With this we fix errors and with the other one we can fix coverage. If you prefer, we can fix everything there, but that will take a bit more time.
Yes, correct. With this we fix errors and with the other one we can fix coverage. If you prefer, we can fix everything there, but that will take a bit more time.
I'd prefer if this is merged as is, so other PRs can move forward while #1438 fixes the coverage.
I agree, thanks.
Thanks @sergiomtzlosa for the fixes already done in #1438. We can keep that PR to solve the coverage problems and use this one to fix asap the errors.
Checklist: