search

qiboteam / qibo

A full-stack framework for quantum computing.
https://qibo.science
Apache License 2.0
294 stars 60 forks source link

Remove deprecation warning, remove old `draw`, and rename `display` as `draw` in `Circuit` class #1464

Closed renatomello closed 1 month ago

renatomello commented 1 month ago

Checklist:

alecandido commented 1 month ago

@renatomello is it here because you want to have it directly in the next release, or is it here just not to forget?

In principle, we should collect breaking changes for 0.3. I would agree that we may be a bit more lenient, but just one/two months after seems a very short notice (especially given the amount of time .draw() has been there since...).

renatomello commented 1 month ago

@renatomello is it here because you want to have it directly in the next release, or is it here just not to forget?

In principle, we should collect breaking changes for 0.3. I would agree that we may be a bit more lenient, but just one/two months after seems a very short notice (especially given the amount of time .draw() has been there since...).

The current warning says the change would happen in 0.2.13.

alecandido commented 1 month ago

The current warning says the change would happen in 0.2.13.

Ok, I've not been careful in reviewing that...

It's a small thing, and updating broken third-party code because of that won't be a massive effort. We can make an exception...

Still, I'd like to increasingly improve our stability guarantees. We should definitely lower the number of semver exceptions abruptly, getting to zero as fast as possible...

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.94%. Comparing base (1675510) to head (6d8624f). Report is 10 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1464 +/- ## ======================================= Coverage 99.94% 99.94% ======================================= Files 81 81 Lines 11740 11737 -3 ======================================= - Hits 11733 11731 -2 + Misses 7 6 -1 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibo/pull/1464/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibo/pull/1464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `99.94% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

renatomello commented 1 month ago

@stavros11 can you confirm the right behavior before I merge this?