qiboteam / qibocal

Quantum calibration, characterization and validation module for Qibo.
https://qibo.science
Apache License 2.0
31 stars 7 forks source link

Fix bug in chevron fitting #825

Closed andrea-pasquale closed 4 months ago

andrea-pasquale commented 5 months ago

This PR fixes a bug that I saw in the fit for the chevron: http://login.qrccluster.com:9000/PnNMnXAFT42fu83vinMgkg==

I found out that the amplitude array needed to be reversed to obtain the correct value: http://login.qrccluster.com:9000/wlPO4jUsT1qQmgzkCDtyqg==/

Moreover, since for the Chevron with probabilities there is no point in checking what is happening to the high frequency qubit since we do not have qutrit classification I decided to remove the fit for the high frequency qubit.

Checklist:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.15%. Comparing base (50ad9a7) to head (e809c34). Report is 15 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/qiboteam/qibocal/pull/825/graphs/tree.svg?width=650&height=150&src=pr&token=3EA9ZUNKUY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam)](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) ```diff @@ Coverage Diff @@ ## main #825 +/- ## ========================================== - Coverage 97.18% 97.15% -0.03% ========================================== Files 104 104 Lines 7781 7780 -1 ========================================== - Hits 7562 7559 -3 - Misses 219 221 +2 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibocal/pull/825/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibocal/pull/825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `97.15% <81.81%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [...on/two\_qubit\_interaction/chevron/chevron\_signal.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fcharacterization%2Ftwo_qubit_interaction%2Fchevron%2Fchevron_signal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2NoYXJhY3Rlcml6YXRpb24vdHdvX3F1Yml0X2ludGVyYWN0aW9uL2NoZXZyb24vY2hldnJvbl9zaWduYWwucHk=) | `100.00% <ø> (ø)` | | | [...cterization/two\_qubit\_interaction/chevron/utils.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fcharacterization%2Ftwo_qubit_interaction%2Fchevron%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2NoYXJhY3Rlcml6YXRpb24vdHdvX3F1Yml0X2ludGVyYWN0aW9uL2NoZXZyb24vdXRpbHMucHk=) | `92.10% <ø> (ø)` | | | [...cterization/two\_qubit\_interaction/chsh/protocol.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fcharacterization%2Ftwo_qubit_interaction%2Fchsh%2Fprotocol.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2NoYXJhY3Rlcml6YXRpb24vdHdvX3F1Yml0X2ludGVyYWN0aW9uL2Noc2gvcHJvdG9jb2wucHk=) | `99.36% <ø> (ø)` | | | [...racterization/two\_qubit\_interaction/cz\_virtualz.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fcharacterization%2Ftwo_qubit_interaction%2Fcz_virtualz.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2NoYXJhY3Rlcml6YXRpb24vdHdvX3F1Yml0X2ludGVyYWN0aW9uL2N6X3ZpcnR1YWx6LnB5) | `93.91% <ø> (ø)` | | | [...zation/two\_qubit\_interaction/cz\_virtualz\_signal.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fcharacterization%2Ftwo_qubit_interaction%2Fcz_virtualz_signal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2NoYXJhY3Rlcml6YXRpb24vdHdvX3F1Yml0X2ludGVyYWN0aW9uL2N6X3ZpcnR1YWx6X3NpZ25hbC5weQ==) | `100.00% <ø> (ø)` | | | [...ls/characterization/two\_qubit\_interaction/utils.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fcharacterization%2Ftwo_qubit_interaction%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2NoYXJhY3Rlcml6YXRpb24vdHdvX3F1Yml0X2ludGVyYWN0aW9uL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | | | [...erization/two\_qubit\_interaction/chevron/chevron.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/825?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fcharacterization%2Ftwo_qubit_interaction%2Fchevron%2Fchevron.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2NoYXJhY3Rlcml6YXRpb24vdHdvX3F1Yml0X2ludGVyYWN0aW9uL2NoZXZyb24vY2hldnJvbi5weQ==) | `96.87% <80.00%> (-1.58%)` | :arrow_down: |