Documentation for tof and kernels

[rodolfocarobene]

Hi, I'm trying to be useful. I've added a simple documentation page for the two signal experiments. The two plots are old ones (kernel took from @Jacfomg )... I don't know if any improvement has been done regarding this experiments and if the plots are good enough!

Checklist:

• [ ] Reviewers confirm new code works as expected.
• [ ] Tests are passing.
• [ ] Coverage does not decrease.
• [ ] Documentation is updated.
• [ ] Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
  • [ ] Qibo: master
  • [ ] Qibolab: main
  • [ ] Qibolab_platforms_qrc: main

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.24%. Comparing base (2d6a169) to head (6362cd7).

Additional details and impacted files

[](https://app.codecov.io/gh/qiboteam/qibocal/pull/871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) ```diff @@ Coverage Diff @@ ## add_doc #871 +/- ## =========================================== + Coverage 97.21% 97.24% +0.02% =========================================== Files 108 108 Lines 7982 7982 =========================================== + Hits 7760 7762 +2 + Misses 222 220 -2 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibocal/pull/871/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibocal/pull/871/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `97.24% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/qiboteam/qibocal/pull/871/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam)

[Jacfomg]

Fitting aside which I think is right for that plot, since that increasing slope you may to remove since it is related to the 3D acvity getting filled with photons, and it is not how it is seem in 2D devices as I could check with Zurich and QM. Maybe we should include this in the docs, and somewhere in qibolab that the rfsoc raw acquisition is doing some postprocessing (demodulation at least) that QM and Zurich do not include as part of a RAW acquisition.

[rodolfocarobene]

Thanks for the reviews!

[rodolfocarobene]

I think now the PR itself is fairly good. In the requirements section it is missing the link to the rabi documentation (since this it does not exist for the moment).

How do we want to proceed? Do we want to merge to main all these PR separately or to merge them all to the add_doc branch and all at once to main?

[rodolfocarobene]

Thanks for the reviews! Should I merge this, wait to merge add_doc, try to rebase to main (I have no real idea if this is reasonable)?

[andrea-pasquale]

Feel free to merge in add_doc, thanks!