Some issues I realized while trying to use these routines:
frequency_power was giving some KeyErrors with qubits missing from the initial_twpa_freq and initial_twpa_power dictionaries. I believe these are because the execution part of the routine is nested in the loop that initializates these dictionaries, while I think it should be a separate loop.
It seems that relaxation_time is ignored for both SNR routines as it is not passed in the resonator_spectroscopy call. This ends up using the default relaxation_time from the platform runcard, which is usually much higher than what we need for spectroscopy, thus making execution slower.
Checklist:
[ ] Reviewers confirm new code works as expected.
[x] Tests are passing.
[x] Coverage does not decrease.
[x] Documentation is updated.
[x] Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
Some issues I realized while trying to use these routines:
frequency_power
was giving someKeyError
s withqubit
s missing from theinitial_twpa_freq
andinitial_twpa_power
dictionaries. I believe these are because the execution part of the routine is nested in the loop that initializates these dictionaries, while I think it should be a separate loop.relaxation_time
is ignored for both SNR routines as it is not passed in theresonator_spectroscopy
call. This ends up using the defaultrelaxation_time
from the platform runcard, which is usually much higher than what we need for spectroscopy, thus making execution slower.Checklist:
master
main
main