qiboteam / qibocal

Quantum calibration, characterization and validation module for Qibo.
https://qibo.science
Apache License 2.0
30 stars 7 forks source link

Fix Advanced example in doc #903

Closed rodolfocarobene closed 3 months ago

rodolfocarobene commented 3 months ago

Closes #901 (work in progress for now)

Checklist:

alecandido commented 3 months ago

I didn't suggest this before, since it will change again with #869. However, that change will be just an addition, so we should be able to keep the updated material that will be produced in this PR.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.42%. Comparing base (0625d90) to head (1305045).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/qiboteam/qibocal/pull/903/graphs/tree.svg?width=650&height=150&src=pr&token=3EA9ZUNKUY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam)](https://app.codecov.io/gh/qiboteam/qibocal/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) ```diff @@ Coverage Diff @@ ## main #903 +/- ## ========================================== - Coverage 97.48% 97.42% -0.07% ========================================== Files 116 116 Lines 8882 8882 ========================================== - Hits 8659 8653 -6 - Misses 223 229 +6 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibocal/pull/903/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibocal/pull/903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `97.42% <ø> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/qiboteam/qibocal/pull/903/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam)
rodolfocarobene commented 3 months ago

Now everything should be working. I guess that there is no need to expand more since things will soon change with #869

andrea-pasquale commented 3 months ago

@scarrazza after I merge this PR we can proceed with the release for qibocal.