Fixing fft guess

[andrea-pasquale]

Closes https://github.com/qiboteam/qibocal/issues/897.

Checklist:

• [ ] Reviewers confirm new code works as expected.
• [ ] Tests are passing.
• [ ] Coverage does not decrease.
• [ ] Documentation is updated.
• [ ] Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
  • [ ] Qibo: master
  • [ ] Qibolab: main
  • [ ] Qibolab_platforms_qrc: main

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.46%. Comparing base (b0dabce) to head (a5141fd). Report is 3 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) ```diff @@ Coverage Diff @@ ## main #915 +/- ## ========================================== + Coverage 97.41% 97.46% +0.04% ========================================== Files 117 117 Lines 8905 8874 -31 ========================================== - Hits 8675 8649 -26 + Misses 230 225 -5 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibocal/pull/915/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibocal/pull/915/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `97.46% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [src/qibocal/protocols/drag.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fdrag.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2RyYWcucHk=) | `96.33% <100.00%> (-0.17%)` | :arrow_down: | | [src/qibocal/protocols/flipping.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fflipping.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2ZsaXBwaW5nLnB5) | `97.89% <100.00%> (-0.17%)` | :arrow_down: | | [src/qibocal/protocols/flipping\_signal.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Fflipping_signal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL2ZsaXBwaW5nX3NpZ25hbC5weQ==) | `98.50% <100.00%> (-0.09%)` | :arrow_down: | | [src/qibocal/protocols/rabi/amplitude.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Frabi%2Famplitude.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL3JhYmkvYW1wbGl0dWRlLnB5) | `96.87% <100.00%> (ø)` | | | [src/qibocal/protocols/rabi/amplitude\_frequency.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Frabi%2Famplitude_frequency.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL3JhYmkvYW1wbGl0dWRlX2ZyZXF1ZW5jeS5weQ==) | `97.91% <100.00%> (-0.03%)` | :arrow_down: | | [...bocal/protocols/rabi/amplitude\_frequency\_signal.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Frabi%2Famplitude_frequency_signal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL3JhYmkvYW1wbGl0dWRlX2ZyZXF1ZW5jeV9zaWduYWwucHk=) | `98.36% <100.00%> (-0.02%)` | :arrow_down: | | [src/qibocal/protocols/rabi/amplitude\_signal.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Frabi%2Famplitude_signal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL3JhYmkvYW1wbGl0dWRlX3NpZ25hbC5weQ==) | `97.46% <100.00%> (+0.03%)` | :arrow_up: | | [src/qibocal/protocols/rabi/length.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Frabi%2Flength.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL3JhYmkvbGVuZ3RoLnB5) | `100.00% <100.00%> (+2.70%)` | :arrow_up: | | [src/qibocal/protocols/rabi/length\_frequency.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Frabi%2Flength_frequency.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL3JhYmkvbGVuZ3RoX2ZyZXF1ZW5jeS5weQ==) | `97.93% <100.00%> (ø)` | | | [.../qibocal/protocols/rabi/length\_frequency\_signal.py](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree&filepath=src%2Fqibocal%2Fprotocols%2Frabi%2Flength_frequency_signal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9jYWwvcHJvdG9jb2xzL3JhYmkvbGVuZ3RoX2ZyZXF1ZW5jeV9zaWduYWwucHk=) | `98.37% <100.00%> (ø)` | | | ... and [7 more](https://app.codecov.io/gh/qiboteam/qibocal/pull/915?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/qiboteam/qibocal/pull/915/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam)

[rodolfocarobene]

Sorry, this PR closes which issue? #651 seems just an old PR. Anyway, it looks good to me, but I don't understand exactly what it is doing, was the fft not working before?

[andrea-pasquale]

Sorry, this PR closes which issue? #651 seems just an old PR. Anyway, it looks good to me, but I don't understand exactly what it is doing, was the fft not working before?

Thanks @rodolfocarobene I linked the wrong issue. It was working before, now it seems that during some refactor something went wrong... Now it should work properly.