search

qiboteam / qibojit-benchmarks

Benchmark code for qibojit performance accessment
Apache License 2.0
2 stars 3 forks source link

Add platform option for Qibo #32

Closed mlazzarin closed 2 years ago

mlazzarin commented 2 years ago

I added a platform setter for Qibo, in both the main.py and compare.py benchmarks. Let me know if it's fine or I am missing something.

scarrazza commented 2 years ago

Looks fine, but I am wondering if we should use platform=None instead.

mlazzarin commented 2 years ago

Thanks for the feedback, I changed the default value of platform to None and I also removed the if statements, it shouldn't create unwanted behaviors, right?

mlazzarin commented 2 years ago

Thanks! I added the platform to the logs. Shall we merge this?