search

qiboteam / qibojit

Accelerating Qibo simulation with just-in-time compilation.
https://qibo.science
Apache License 2.0
15 stars 3 forks source link

Adding `cupy` exponentiation method #179

Closed andrea-pasquale closed 6 months ago

andrea-pasquale commented 7 months ago

Closes https://github.com/qiboteam/qibo/issues/1068 The new primitive is available only for cupy 13.1.0.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.91%. Comparing base (de78b0d) to head (7d46da4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ========================================== - Coverage 99.91% 99.91% -0.01% ========================================== Files 12 12 Lines 1115 1114 -1 ========================================== - Hits 1114 1113 -1 Misses 1 1 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibojit/pull/179/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibojit/pull/179/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `99.91% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrea-pasquale commented 7 months ago

Tests are failing on cuquantum with the lastest version, with 23.10 they seem to pass.

andrea-pasquale commented 7 months ago

The following test is failing on GPU for both cupy and cuquantum https://github.com/qiboteam/qibojit/blob/f062f8733b039c12442eb7570c17740d274d568d/src/qibojit/tests/test_ops.py#L78-L99 It require a fix in qibo which I can implement.