search

qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

Make `Envelope` type public #1054

Closed stavros11 closed 2 hours ago

stavros11 commented 2 hours ago

I wonder whether we should make this public, and reintroduce this comment (here or somewhere else).

It is true that it is annotated with Envelope, but that's the base class, while the other one is the enumeration...

However, this is definitely not for 0.2.0

_Originally posted by @alecandido in https://github.com/qiboteam/qibolab/pull/1053#discussion_r1767686653_

stavros11 commented 2 hours ago

In the end it was already public and the comment was reintroduced in 49133dcf2eb3a0be78e4ae0f8fa70436216b724a.