Closed PiergiorgioButtarini closed 9 months ago
Attention: 28 lines
in your changes are missing coverage. Please review.
Comparison is base (
d5cd108
) 61.90% compared to head (e8eccf0
) 61.99%. Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For the conflicts you can merge main, accept the current change (not the ones from main) for all conflicts and then apply the pre-commit or just try to commit so that pre-commit is applied. I am not sure if that's the easiest approach but that's what I usually do in this case.
Thanks @stavros11 I'll do it.
@PiergiorgioButtarini thank you for the updates. I opened issues for some unresolved discussions above. Following the meeting, I will now merge this.
Changes
This PR simplify the Qblox instruments removing the necessity of an ulterior object
Cluster
. All the feature connected to theCluster
class, essentially only the settings of the reference clock, were moved into the qbloxController
. Some simplification in theacquire()
ofcluster_qrm_rf
were also made. Linked to PR https://github.com/qiboteam/qibolab_platforms_qrc/pull/95TODO
New qpu test implemented for controller but are not executed
Checklist: