qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

Remove Qblox `Cluster` #702

Closed PiergiorgioButtarini closed 9 months ago

PiergiorgioButtarini commented 9 months ago

Changes

This PR simplify the Qblox instruments removing the necessity of an ulterior object Cluster. All the feature connected to the Cluster class, essentially only the settings of the reference clock, were moved into the qblox Controller. Some simplification in the acquire() of cluster_qrm_rf were also made. Linked to PR https://github.com/qiboteam/qibolab_platforms_qrc/pull/95

TODO

New qpu test implemented for controller but are not executed

Checklist:

codecov[bot] commented 9 months ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (d5cd108) 61.90% compared to head (e8eccf0) 61.99%. Report is 3 commits behind head on main.

Files Patch % Lines
src/qibolab/instruments/qblox/cluster_qrm_rf.py 20.00% 12 Missing :warning:
src/qibolab/instruments/qblox/controller.py 35.71% 9 Missing :warning:
src/qibolab/instruments/qblox/cluster_qcm_bb.py 42.85% 4 Missing :warning:
src/qibolab/instruments/qblox/cluster_qcm_rf.py 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #702 +/- ## ========================================== + Coverage 61.90% 61.99% +0.08% ========================================== Files 49 48 -1 Lines 6810 6746 -64 ========================================== - Hits 4216 4182 -34 + Misses 2594 2564 -30 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `61.99% <33.33%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stavros11 commented 9 months ago

For the conflicts you can merge main, accept the current change (not the ones from main) for all conflicts and then apply the pre-commit or just try to commit so that pre-commit is applied. I am not sure if that's the easiest approach but that's what I usually do in this case.

PiergiorgioButtarini commented 9 months ago

Thanks @stavros11 I'll do it.

stavros11 commented 9 months ago

@PiergiorgioButtarini thank you for the updates. I opened issues for some unresolved discussions above. Following the meeting, I will now merge this.